Code review comment for ~paelzer/ubuntu/+source/openssh:fix-1863930-ssh-version-advertise-bionic

Revision history for this message
Bryce Harrington (bryce) wrote :

* Changelog:
  - [-] old content and logical tag match as expected
  - [√] changelog entry correct version and targeted codename
  - [√] changelog entries correct
  - [√] update-maintainer has been run

* Actual changes:
  - [-] no upstream changes to consider
  - [-] no further upstream version to consider
  - [-] debian changes look safe

* Old Delta:
  - [-] dropped changes are ok to be dropped
  - [-] nothing else to drop
  - [√] changes forwarded upstream/debian (if appropriate)

* New Delta:
  - [-] no new patches added
  - [√] patches match what was proposed upstream
  - [√] patches correctly included in debian/patches/series
  - [√] patches have correct DEP3 metadata

* Build/Test:
  - [√] build is ok
  - [ ] verified PPA package installs/uninstalls
  - [ ] autopkgtest against the PPA package passes
  - [ ] sanity checks test fine

I seem to be unable to install from the bileto PPA:

  $ sudo add-apt-repository -s ppa:ci-train-ppa-service/3962
  ...
  Err:3 http://ppa.launchpad.net/ci-train-ppa-service/3962/ubuntu focal Release
  404 Not Found [IP: 91.189.95.83 80]
  Reading package lists... Done
  E: The repository 'http://ppa.launchpad.net/ci-train-ppa-service/3962/ubuntu focal Release' does not have a Release file.
  N: Updating from such a repository can't be done securely, and is therefore disabled by default.
  N: See apt-secure(8) manpage for repository creation and user configuration details.

I tried adding [trusted=yes], but then get this error:

Ign:14 http://ppa.launchpad.net/ci-train-ppa-service/3962/ubuntu focal/main amd64 c-n-f Metadata
Reading package lists... Done
E: Failed to fetch http://ppa.launchpad.net/ci-train-ppa-service/3962/ubuntu/dists/focal/main/source/Sources 404 Not Found [IP: 91.189.95.83 80]
E: Some index files failed to download. They have been ignored, or old ones used instead.

I thought maybe this might be a vpn issue, and tinkered with that a bit but no such luck. If you have advice I can try more. Or maybe setting up a non-bileto PPA might work better?

Anyway, apart from testing the ppa everything else looks good to go, and I know the testing will have to be done for the SRU (and has been requested of the original reporter) so am giving a provisional +1, and trust the testing will be covered separately.

review: Approve

« Back to merge proposal