Code review comment for ~paelzer/ubuntu/+source/open-iscsi:merge-2.1.4-impish

On Fri, Jul 02, 2021 at 05:55:11AM -0000, Christian Ehrhardt  wrote:
> Thanks for the review!
>
> The bullet style was taken as it was in the past, but thanks for the hint - I've updated the Changelog for it.
>
> The autopkgtests on Bileto didn't all kick in, so I had them running myself against the PPA on LP. That was good, I've realized one more thing that would be a pain.
>
> Upgrading a cloud image revealed
> (Reading database ... 65987 files and directories currently installed.)
> Preparing to unpack .../libopeniscsiusr_2.1.4-0ubuntu1~impishppa1_amd64.deb ...
> Unpacking libopeniscsiusr (2.1.4-0ubuntu1~impishppa1) ...
> dpkg: error processing archive /var/cache/apt/archives/libopeniscsiusr_2.1.4-0ubuntu1~impishppa1_amd64.deb (--unpack):
> trying to overwrite '/usr/lib/x86_64-linux-gnu/libopeniscsiusr.so.0.2.0', which is also in package libopeniscsiusr0.2.0 2.1.3-1ubuntu6
> Preparing to unpack .../open-iscsi_2.1.4-0ubuntu1~impishppa1_amd64.deb ...
> Unpacking open-iscsi (2.1.4-0ubuntu1~impishppa1) over (2.1.3-1ubuntu6) ...
> Errors were encountered while processing:
> /var/cache/apt/archives/libopeniscsiusr_2.1.4-0ubuntu1~impishppa1_amd64.deb
>
> That makes sense as from a Ubuntu users POV the merge implies a file rename. I'll add what is needed as that is a trivial common case.

Ahhh, in fact I ran into this problem too when I initially installed.
But then I removed/purged and reinstalled and then I couldn't figure out
how to reproduce it, so figured I just had something misconfigured to
begin with. That makes more sense though.

> --
> https://code.launchpad.net/~paelzer/ubuntu/+source/open-iscsi/+git/open-iscsi/+merge/405043
> You are reviewing the proposed merge of ~paelzer/ubuntu/+source/open-iscsi:merge-2.1.4-impish into ubuntu/+source/open-iscsi:debian/sid.