Ubuntu
open-iscsi package

Code review comment for ~paelzer/ubuntu/+source/open-iscsi:lp-1922976-finalrd-logout-HIRSUTE

  1. Git
  2. lp:~paelzer/ubuntu/+source/open-iscsi
  3. lp-1922976-finalrd-logout-HIRSUTE
  4. Merge into ubuntu/hirsute-devel
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Hi Christian,

> If all here looks good, then it should be up to me to wait for
> everything else to be complete as well :-) That way I can
> control the potential extra delay instead of waiting for a
> re-review then.

Of course. I did mention that the changes look good in the very first sentence of the initial review and wrote about the other concerns/questions/curiosities, heh :)

That said, here's the more official review:

* Changelog:
  - [✔] changelog entry correct version and targeted codename
  - [✔] changelog entries correct
  - [✔] update-maintainer has been run

* Actual changes:
  - [✔] no upstream changes to consider
  - [✔] no further upstream version to consider
  - [✔] debian changes look safe

* New Delta:
  - [✔] no new patches added

* Build/Test:
  - [✔] build is ok
  - [✔] verified PPA package installs/uninstalls
  - [✔] sanity checks test fine

Thanks to Michael Brown for testing this fix! \o/

« Back to merge proposal