Ubuntu
open-iscsi package

Code review comment for ~paelzer/ubuntu/+source/open-iscsi:merge-2.1.2-1-HIRSUTE

  1. Git
  2. lp:~paelzer/ubuntu/+source/open-iscsi
  3. merge-2.1.2-1-HIRSUTE
  4. Merge into debian/sid
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

1) I don't think 6c13643 "Don't FTBFS due to warnings new in gcc10" is needed any more with this new upstream release. My local test build without it succeeded.

=> I thought the same, had it test built and it fails on ppc64&s390x still without this

2) 5dd176f

I'll look into that, the surrounding context had some noise distracting me.
Indeed I have alinged to what the comment said, but to match the old delta the line has dropped iscsiuio.socket indeed
Awesome spotting on the review.
Fixed

And about logical - this was not intentionally different. The problem is that some squashing only becomes obvious once you are 3/4 through the merge. I did not go back to refresh logical with those, but yeah I might do so next time.

« Back to merge proposal