Ubuntu
libvirt package

Code review comment for ~paelzer/ubuntu/+source/libvirt:merge-8.0-jammy

  1. Git
  2. lp:~paelzer/ubuntu/+source/libvirt
  3. merge-8.0-jammy
  4. Merge into debian/sid
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

On Tuesday, February 01 2022, Christian Ehrhardt  wrote:

> FYI @Sergio:
> Only using "--no-start" compared to what I proposed "--no-stop-on-upgrade --no-start" only drops a snippet in prerm that will stop the services on removal.
> That isn't helping, if they were started it is indeed helpful to stop them before rmeoval.
> For install/upgrade this snippet has no effect.
> Therefore I'd - for now - leave it as "--no-stop-on-upgrade --no-start" which is the most explicit expression of "do not do anything please".
>
> I'll rebuild with the former again ...

Thanks for the follow up, Christian. BTW, not having the git-ubuntu
tags was no pain; I just had to improvise with git, but that's fine.

FWIW, thank you for double-checking what removing "--no-stop-on-upgrade"
causes. Based on your findings I agree that it's OK to leave the option
as is. I'm also hoping that this bug will be fixed before the release,
and that you will be able to drop this particular delta soon.

Anyway, with all of this out of the way, the MP now LGTM. +1.

Cheers,

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14

« Back to merge proposal