Code review comment for ~paelzer/ubuntu/+source/libvirt:merge-8.0-jammy

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Yeah sorry, co-developing so much on Salsa makes me forget to provide the usual set of tags. Also we went ahead of Debian multiple times but fetching commits from salsa in those, which makes our past look noisy.
Due to always maintaining with git-ubuntu the TL;DR is pkg/ubuntu/jammy-devel == deconstruct, so it isn't too hard despite looking ugly.
Here they are:
To ssh://git.launchpad.net/~paelzer/ubuntu/+source/libvirt
 * [new tag] merge-8.0-jammy-former-deconstruct -> merge-8.0-jammy-former-deconstruct
 * [new tag] merge-8.0-jammy-former-logical -> merge-8.0-jammy-former-logical
Next time just remind me instead of feeling the pain, I'll then do my duty to create and provide them right away.

The debhelper/systemd situation is still up for debate and discussion in the Debian PR and debian bug.
I'm gonna upload libvirt once we have settled there.
Your suggestion of dropping --no-stop-on-upgrade is interesting, I rechecked and dbus uses an even more confusing "--no-restart-after-upgrade --no-start". I'll have a look and also try only using "--no-start".
The currently proposed code does work through all tests that I found, which is why I'd like to keep it until I had time to find a better one :-)
If the Debian discussions take too long I might upload libvirt as proposed here "for now" and later once (as discussed in standup) we know how bug 1959054 resolves for Ubuntu rewrite it depending on that.
TL;DR - something working for now, resolve it before jammy-release

Thanks for the inline comments, I'll have a look at each of them ...

« Back to merge proposal