Ubuntu
libvirt package

Code review comment for ~paelzer/ubuntu/+source/libvirt:lp-1927519-corrupted-1948880-swtpm-JAMMY

  1. Git
  2. lp:~paelzer/ubuntu/+source/libvirt
  3. lp-1927519-corrupted-1948880-swtpm-JAMMY
  4. Merge into ubuntu/jammy-devel
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Ah, the rebuild worked :-). I had the impression that the failures were flaky, and apparently they are. Also, I noticed that you've faced the same failures on s390x. Interesting...

Anyway, here's the review I promised.

I'm OK with the patch to address the apparmor issue.

As for the swtpm thing, I read the entire bug and I am also a bit uncomfortable with the scenario #2 (upgrade) that you described there, specifically about the problem with permissions and the implications this will have for SRUs. But as you said there, this looks fine for Jammy and I don't really have anything bad to say for this specific MP.

I found a bunch of small nits here and there; I'm leaving inline comments for them.

Otherwise, this LGTM with those fixed, so I'm approving it in advance.

Thanks!

review: Approve

« Back to merge proposal