Ubuntu
ipxe package

Code review comment for ~paelzer/ubuntu/+source/ipxe:fix-lp1805920-vlan0-tag-stripping-bionic

  1. Git
  2. lp:~paelzer/ubuntu/+source/ipxe
  3. fix-lp1805920-vlan0-tag-stripping-bionic
  4. Merge into ubuntu/bionic-devel
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I see the bug is still marked as incomplete, and pending a test case, but that doesn't block review.

The DEP3 header is lacking Last-Update, and maybe a link to the upstream commit? The centos commit hints that upstream sent a patch (or a patch was sent upstream), but it's the same person (Ladi?). The ubuntu bug says that upstream didn't "follow the suggestion", is there a link to some discussion, upstream bug, or mailing list post? The mailing list link in the centos patch has just one post, no thread that followed.

For the actual upload, I think only a test case is missing in the SRU template, if that's even doable. This may require a somewhat complex setup to test.

I'll mark as needs info just because of the questions above.

review: Needs Information

« Back to merge proposal