Merge ~paelzer/ubuntu/+source/gpsd:lp-1879272-json-quotes-on-add-GROOVY into ubuntu/+source/gpsd:ubuntu/groovy-devel

Proposed by Christian Ehrhardt 
Status: Rejected
Rejected by: Christian Ehrhardt 
Proposed branch: ~paelzer/ubuntu/+source/gpsd:lp-1879272-json-quotes-on-add-GROOVY
Merge into: ubuntu/+source/gpsd:ubuntu/groovy-devel
Diff against target: 90 lines (+44/-2)
5 files modified
debian/changelog (+6/-0)
debian/control (+2/-1)
debian/control.in (+2/-1)
debian/patches/lp-1879272-gpsd-Quote-the-activated-timestamp-in-the-json-paylo.patch (+33/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Canonical Server Pending
Canonical Server packageset reviewers Pending
git-ubuntu developers Pending
Review via email: mp+384232@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

accepted and uploaded and synced via https://salsa.debian.org/debian-gps-team/pkg-gpsd/-/merge_requests/8

Abanoning this MP as it is no more needed.

Unmerged commits

78655b6... by Christian Ehrhardt 

update-maintainer

Signed-off-by: Christian Ehrhardt <email address hidden>

958a483... by Christian Ehrhardt 

changelog: fix json missing quotes on device add (LP: #1879272)

Signed-off-by: Christian Ehrhardt <email address hidden>

4e389be... by Christian Ehrhardt 

fix json missing quotes on device add (LP: #1879272)

Signed-off-by: Christian Ehrhardt <email address hidden>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 2e76731..2802816 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+gpsd (3.20-11ubuntu1) groovy; urgency=medium
7+
8+ * fix json missing quotes on device add (LP: #1879272)
9+
10+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Wed, 20 May 2020 08:23:02 +0200
11+
12 gpsd (3.20-11) unstable; urgency=medium
13
14 [ Christian Ehrhardt ]
15diff --git a/debian/control b/debian/control
16index 5ff5787..fb6fe2c 100644
17--- a/debian/control
18+++ b/debian/control
19@@ -1,7 +1,8 @@
20 Source: gpsd
21 Section: misc
22 Priority: optional
23-Maintainer: Bernd Zeimetz <bzed@debian.org>
24+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
25+XSBC-Original-Maintainer: Bernd Zeimetz <bzed@debian.org>
26 Build-Depends: debhelper (>= 11),
27 po-debconf,
28 python3-all-dev (>= 2.6.6-3),
29diff --git a/debian/control.in b/debian/control.in
30index 342d813..808982a 100644
31--- a/debian/control.in
32+++ b/debian/control.in
33@@ -1,7 +1,8 @@
34 Source: gpsd
35 Section: misc
36 Priority: optional
37-Maintainer: Bernd Zeimetz <bzed@debian.org>
38+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
39+XSBC-Original-Maintainer: Bernd Zeimetz <bzed@debian.org>
40 Build-Depends: debhelper (>= 11),
41 po-debconf,
42 python3-all-dev (>= 2.6.6-3),
43diff --git a/debian/patches/lp-1879272-gpsd-Quote-the-activated-timestamp-in-the-json-paylo.patch b/debian/patches/lp-1879272-gpsd-Quote-the-activated-timestamp-in-the-json-paylo.patch
44new file mode 100644
45index 0000000..807e892
46--- /dev/null
47+++ b/debian/patches/lp-1879272-gpsd-Quote-the-activated-timestamp-in-the-json-paylo.patch
48@@ -0,0 +1,33 @@
49+From 733495192307d43c9e3bdd9e1b202045e66d998b Mon Sep 17 00:00:00 2001
50+From: Andreas Tobler <andreas.tobler@onway.ch>
51+Date: Thu, 14 May 2020 20:30:19 +0200
52+Subject: [PATCH] gpsd: Quote the activated timestamp in the json payload
53+
54+Without the quotes we get this as DECVICE json payload:
55+
56+{"class":"DEVICE","path":"/dev/pts/9","activateed":2020-05-14T15:36:35.087Z}
57+
58+This results in a json parse error after the 2020.
59+Fix this with quoting the timestamp.
60+
61+Signed-off-by: Gary E. Miller <gem@rellim.com>
62+
63+Origin: backport, https://gitlab.com/gpsd/gpsd/-/commit/733495192307d43c9e3bdd9e1b2020
64+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1879272
65+Last-Update: 2020-05-20
66+
67+---
68+ gpsd.c | 2 +-
69+ 1 file changed, 1 insertion(+), 1 deletion(-)
70+
71+--- a/gpsd.c
72++++ b/gpsd.c
73+@@ -748,7 +748,7 @@ bool gpsd_add_device(const char *device_
74+ #ifdef SOCKET_EXPORT_ENABLE
75+ notify_watchers(devp, true, false,
76+ "{\"class\":\"DEVICE\",\"path\":\"%s\","
77+- "\"activated\":%s}\r\n",
78++ "\"activated\":\"%s\"}\r\n",
79+ devp->gpsdata.dev.path,
80+ now_to_iso8601(tbuf, sizeof(tbuf)));
81+ #endif /* SOCKET_EXPORT_ENABLE */
82diff --git a/debian/patches/series b/debian/patches/series
83index f5e43d9..cd24696 100644
84--- a/debian/patches/series
85+++ b/debian/patches/series
86@@ -5,3 +5,4 @@ gpsd_hotplug_rules_disable_generic_serial_converters
87 0001-Fix-merging-and-using-of-python-flags.patch
88 ignore-test-xgps_deps_check
89 fix-soname
90+lp-1879272-gpsd-Quote-the-activated-timestamp-in-the-json-paylo.patch

Subscribers

People subscribed via source and target branches