Merge ~paelzer/ubuntu/+source/freeradius:avoid-collectd-component-mismatch into ubuntu/+source/freeradius:ubuntu/devel

Proposed by Christian Ehrhardt 
Status: Merged
Approved by: Christian Ehrhardt 
Approved revision: 858e7d9514fd65758cb0837c97d0b5d99ada2280
Merged at revision: 858e7d9514fd65758cb0837c97d0b5d99ada2280
Proposed branch: ~paelzer/ubuntu/+source/freeradius:avoid-collectd-component-mismatch
Merge into: ubuntu/+source/freeradius:ubuntu/devel
Diff against target: 35 lines (+9/-2)
2 files modified
debian/changelog (+7/-0)
debian/control (+2/-2)
Reviewer Review Type Date Requested Status
Lucas Kanashiro (community) Approve
Canonical Server Core Reviewers Pending
Review via email: mp+384017@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

From what I've seen, this MP seems fine :-). I'm not officially reviewing it because I'd like someone more experienced to double check.

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

* Changelog:
  - [-] old content and logical tag match as expected
  - [√] changelog entry correct version and targeted codename
  - [√] changelog entries correct
  - [√] update-maintainer has been run

* Actual changes:
  - [√] no upstream changes to consider
  - [√] no further upstream version to consider
  - [√] debian changes look safe

* Old Delta:
  - [-] dropped changes are ok to be dropped
  - [-] nothing else to drop
  - [-] changes forwarded upstream/debian (if appropriate)

* New Delta:
  - [√] no new patches added
  - [-] patches match what was proposed upstream
  - [-] patches correctly included in debian/patches/series
  - [-] patches have correct DEP3 metadata

* Build/Test:
  - [√] build is ok
  - [-] verified PPA package installs/uninstalls
  - [-] autopkgtest against the PPA package passes
  - [√] sanity checks test fine

+1. I agree with Sergio, LGTM. There is no PPA but I built it locally and it seems fine.

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

He, I had the PPA but the update to the MP pointing to it got a timeout and I didn't look for it again.

=> https://bileto.ubuntu.com/#/ticket/4064
=> https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4064/+packages

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

To ssh://git.launchpad.net/ubuntu/+source/freeradius
 * [new tag] upload/3.0.21+dfsg-1ubuntu1 -> upload/3.0.21+dfsg-1ubuntu1

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading freeradius_3.0.21+dfsg-1ubuntu1.dsc: done.
  Uploading freeradius_3.0.21+dfsg.orig.tar.xz: done.
  Uploading freeradius_3.0.21+dfsg-1ubuntu1.debian.tar.xz: done.
  Uploading freeradius_3.0.21+dfsg-1ubuntu1_source.buildinfo: done.
  Uploading freeradius_3.0.21+dfsg-1ubuntu1_source.changes: done.
Successfully uploaded packages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 1d56a48..6e85a6f 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+freeradius (3.0.21+dfsg-1ubuntu1) groovy; urgency=medium
7+
8+ * d/control: Drop collectd integration for being in universe (LP: #1878778)
9+ * Merging this will also satisfy (LP: #1870340) asking for 3.0.21+dfsg-1
10+
11+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Fri, 15 May 2020 10:27:59 +0200
12+
13 freeradius (3.0.21+dfsg-1) unstable; urgency=medium
14
15 [ Bernhard Schmidt ]
16diff --git a/debian/control b/debian/control
17index 9f2f926..d8bc1d7 100644
18--- a/debian/control
19+++ b/debian/control
20@@ -29,13 +29,13 @@ Build-Depends: debhelper (>= 10.6),
21 python3-dev,
22 samba-dev | samba4-dev,
23 libpcre3-dev,
24- libcollectdclient-dev,
25 snmp,
26 dh-autoreconf,
27 freetds-dev
28 Section: net
29 Priority: optional
30-Maintainer: Debian FreeRADIUS Packaging Team <pkg-freeradius-maintainers@lists.alioth.debian.org>
31+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
32+XSBC-Original-Maintainer: Debian FreeRADIUS Packaging Team <pkg-freeradius-maintainers@lists.alioth.debian.org>
33 Uploaders: Mark Hymers <mhy@debian.org>,
34 Sam Hartman <hartmans@debian.org>,
35 Bernhard Schmidt <berni@debian.org>

Subscribers

People subscribed via source and target branches