Code review comment for ~paelzer/ubuntu/+source/chrony:merge-4.2-2-jammy

Hiya,

> 0526a15 and all the others you asked for were forwarded to Debian
> and there decided against it.
>
> The reason behind that is that our container story around LXD being
> a system container is very different to theirs.
>
> Without that motivation I can understand why they didn't want but
> we needed it.
> So that is one of the "fair and ok on both sides" differences
> between Debian & Ubuntu.
>
> All the other bits you have wondered belong to that context e.g.
> libcap2-bin is only needed for our container check. The call to
> the wrapper is only needed for our container handling, ...

Okay, fair enough. I'd like to propose adding a "[Ubuntu-specific]" tags to the commit (message) header so that the reviewer directly knows that it is more-or-less Ubuntu-only or/and equivalent. Maybe I'll bring this to our stand-up sometime this week.

> If you want them added it is just a copy of lines 90-92 up to
> 29 and done.
> So let me know if you think this is really better.

I don't have a problem, really. Either is fine now that there is context but maybe adding them would be better? But really, up to you. If you think it's not needed, so be it. \o/

Given everything has been answered/discussed, this looks good. +1.