Code review comment for ~paelzer/ubuntu/+source/chrony:merge-3.5-eoan

Okay,

Checked LP numbers and descriptions, modified debian/ files through history, compiled, installed, de-installed, purged, upgraded, all good. Tested chronyd tracking:

$ chronyc tracking
Reference ID : C8A007C1 (gps.ntp.br)
Stratum : 3
Ref time (UTC) : Tue Jul 16 12:15:54 2019
System time : 0.000272425 seconds slow of NTP time
Last offset : -3.252692461 seconds
RMS offset : 3.252692461 seconds
Frequency : 21.290 ppm slow
Residual freq : -0.000 ppm
Skew : 42.520 ppm
Root delay : 0.009401247 seconds
Root dispersion : 0.004084035 seconds
Update interval : 64.4 seconds
Leap status : Normal

And ran autopkgtest. I had the same failures as previous versions were having, due to other unrelated (to this merge) things.

1) The systemd issue:
md5sum: /run/systemd/resolved.conf.d/isc-dhcp-v4-dummy0.conf: No such file or directory

2)

FAILED 2 (111-knownclient 112-port) (23644 23645 23646 23647 23648 23649 23650 23651 23652 23653 23654 23655 23656 23657 23658 23659 23660 23661 23662 23663 23644 23645 23646 23647 23648 23649 23650 23651 23652 23653 23654 23655 23656 23657 23658 23659 23660 23661 23662 23663 23662)

111-knownclient xxxxxxxxxxxxxxxxxxxx FAIL
112-port xxxxxxxxxxxxxxxxxxxx FAIL

(this also occurred in other tests for 3.4-4ubuntu2, since iproute2/4.18.0-1ubuntu3 triggered the test)

Are you aware of what caused this ^ ?

Anyway, I'm +1 on this merge since those tests were failing before it.