Ubuntu
binutils package

Code review comment for ~paelzer/ubuntu/+source/binutils:lp-1883880-x86-don-t-mistakenly-scale-non-8-bit-BIONIC

  1. Git
  2. lp:~paelzer/ubuntu/+source/binutils
  3. lp-1883880-x86-don-t-mistakenly-scale-non-8-bit-BIONIC
  4. Merge into ubuntu/bionic-devel
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Doko is unavailable atm, but on direct contact he gave it a quick look and called it to be ok (on a superficial check).

Furthermore the pre-checks LGTM with all fails being known overrides in Bionic:
https://bileto.ubuntu.com/excuses/4105/bionic.html

ubuntu-release:9:force-badtest dh-ada-library/6.12
ubuntu-release:18:force-badtest lintian/2.5.81ubuntu1
pitti:2:force-badtest rpmlint/1.9-6
ubuntu-sru:17:force-badtest snapcraft/2.43.1+18.04/amd64 snapcraft/2.43.1+18.04/i386
ubuntu-sru:20:force-badtest snapcraft/2.43.1+18.04/armhf snapcraft/2.43.1+18.04/arm64
ubuntu-release:90:force-badtest linux-hwe/all
ubuntu-release:91:force-badtest linux-hwe-edge/all

Uploading for SRU consideration

I'd still not mind a deeper review by doko once he is back, but it isn't blocking this.

review: Approve

« Back to merge proposal