Merge ~paelzer/ubuntu/+source/autofs:lp-1818121-nfs4.x-bionic into ubuntu/+source/autofs:ubuntu/bionic-devel

Proposed by Christian Ehrhardt 
Status: Merged
Approved by: Andreas Hasenack
Approved revision: f2a043c583081e932093e7c6cc9c5a1d80bf33b9
Merged at revision: f2a043c583081e932093e7c6cc9c5a1d80bf33b9
Proposed branch: ~paelzer/ubuntu/+source/autofs:lp-1818121-nfs4.x-bionic
Merge into: ubuntu/+source/autofs:ubuntu/bionic-devel
Diff against target: 72 lines (+50/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/autofs-5.1.3-handle-additional-nfs-versions-in-mount.patch (+42/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Andreas Hasenack Approve
Canonical Server packageset reviewers Pending
Canonical Server Pending
Review via email: mp+364299@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

PPA can be found at [1] and the same case/changes were just recently evaluated and working for Disco.

[1]: https://launchpad.net/~paelzer/+archive/ubuntu/bug-1818121-autofs-nfs4.x

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

- git range-diff agrees it's the same patch (just context diff in series)
- Disco, cosmic and bionic have the same base version.
- d/changelog version correct for an SRU
- SRU template filled out

+1

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Thanks - tagged and uploaded to -unapproved

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index f268ddc..953854f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
1autofs (5.1.2-1ubuntu3.1) bionic; urgency=medium
2
3 * d/p/autofs-5.1.3-handle-additional-nfs-versions-in-mount.patch:
4 fix usage of NFS 4.x subversions (LP: #1818121)
5
6 -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Thu, 07 Mar 2019 13:03:35 +0100
7
1autofs (5.1.2-1ubuntu3) bionic; urgency=medium8autofs (5.1.2-1ubuntu3) bionic; urgency=medium
29
3 * Revert the previous change, as it introduced a segfault when using the10 * Revert the previous change, as it introduced a segfault when using the
diff --git a/debian/patches/autofs-5.1.3-handle-additional-nfs-versions-in-mount.patch b/debian/patches/autofs-5.1.3-handle-additional-nfs-versions-in-mount.patch
4new file mode 10064411new file mode 100644
index 0000000..fdb0cd0
--- /dev/null
+++ b/debian/patches/autofs-5.1.3-handle-additional-nfs-versions-in-mount.patch
@@ -0,0 +1,42 @@
1From aa1f432180f3878c303088def8d647f1bd50b10b Mon Sep 17 00:00:00 2001
2From: Ian Kent <raven@themaw.net>
3Date: Thu, 19 Oct 2017 08:48:44 +0800
4Subject: [PATCH] autofs-5.1.3 - handle additional nfs versions in mount_nfs.c
5
6Since NFSv4 can now have a subversion it needs to be allowed for.
7
8It's enough to check for an options string starting with "vers=4" or
9"nfsvers=4" because it's used only to set a flag used for special
10casing the availibility probe for any NFS version 4 version.
11
12Signed-off-by: Ian Kent <raven@themaw.net>
13
14Backport Note: skip the hunk on CHANGELOG as it is not needed and lacks
15 the 5.1.3 context it needs
16Author: Christian Ehrhardt <christian.ehrhardt@canonical.com>
17Original-Author: Ian Kent <raven@themaw.net>
18Origin: backport, https://git.kernel.org/pub/scm/linux/storage/autofs/autofs.git/commit/?id=aa1f432180f3878c303088def8d647f1bd50b10b
19
20Bug-Ubuntu: https://bugs.launchpad.net/bugs/<todo-bug>
21Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=<todo-bug>
22Last-Update: 2019-03-07
23
24---
25 CHANGELOG | 1 +
26 modules/mount_nfs.c | 5 +++--
27 2 files changed, 4 insertions(+), 2 deletions(-)
28
29--- a/modules/mount_nfs.c
30+++ b/modules/mount_nfs.c
31@@ -148,8 +148,9 @@ int mount_mount(struct autofs_point *ap,
32 } else if (_strncmp("use-weight-only", cp, o_len) == 0) {
33 flags |= MOUNT_FLAG_USE_WEIGHT_ONLY;
34 } else {
35- if (_strncmp("vers=4", cp, o_len) == 0 ||
36- _strncmp("nfsvers=4", cp, o_len) == 0)
37+ /* Is any version of NFSv4 in the options */
38+ if (_strncmp("vers=4", cp, 6) == 0 ||
39+ _strncmp("nfsvers=4", cp, 9) == 0)
40 vers = NFS4_VERS_MASK | TCP_SUPPORTED;
41 else if (_strncmp("vers=3", cp, o_len) == 0 ||
42 _strncmp("nfsvers=3", cp, o_len) == 0) {
diff --git a/debian/patches/series b/debian/patches/series
index 208f0c9..773f960 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -11,3 +11,4 @@ remove-kernel-mount.nfs-version-check.patch
1116group_buffer_size.patch1116group_buffer_size.patch
12fix-ssslib-search.patch12fix-ssslib-search.patch
13fix-lookup-ldap-crash.patch13fix-lookup-ldap-crash.patch
14autofs-5.1.3-handle-additional-nfs-versions-in-mount.patch

Subscribers

People subscribed via source and target branches