Merge ~paelzer/ubuntu-archive-tools:check-subscription-early into ubuntu-archive-tools:main

[Christian Ehrhardt ]

[Christian Ehrhardt  (paelzer)]

Doko and I found that this check could be way more useful if available earlier.
It is only moving the code that Seb added slightly earlier to achieve that.

[Christian Ehrhardt  (paelzer)]

example with --dry-run and the new code

$ ./change-override -c main vym -s jammy --source-and-binary --dry-run
Override component to main
vym 2.6.11-3build1 in jammy: universe/kde -> main
vym 2.6.11-3build1 in jammy amd64: universe/kde/optional/100% -> main
vym 2.6.11-3build1 in jammy arm64: universe/kde/optional/100% -> main
vym 2.6.11-3build1 in jammy armhf: universe/kde/optional/100% -> main
vym 2.6.11-3build1 in jammy ppc64el: universe/kde/optional/100% -> main
vym 2.6.11-3build1 in jammy riscv64: universe/kde/optional/100% -> main
vym 2.6.11-3build1 in jammy s390x: universe/kde/optional/100% -> main
No known owning team subscribed to 'vym'. Do you really want to promote? [y|N]?

[Christian Ehrhardt  (paelzer)]

I did rebase and push the branch again, just to make sure it is current (no changes needed).
Still need a positive feedback to merge it.

[Chris Halse Rogers (raof)]

That looks sensible to me!

review: Approve

[Christian Ehrhardt  (paelzer)]

Thank you RAOF, merged

diff --git a/change-override b/change-override
index 4b0b940..b4308aa 100755
--- a/change-override
+++ b/change-override
@@ -103,6 +103,32 @@ def change_overrides(options, packages):
                     publication.phased_update_percentage),
                 "/".join(stringify_binary_kwargs(binary_kwargs))))
 
+    # The MIR teams subscription is specific to Ubuntu
+    lpubuntu = None
+    if options.distribution.name == "ubuntu":
+        lpubuntu = options.launchpad.distributions["ubuntu"]
+    for pubtype, publication in publications:
+        if pubtype == "source":
+            if lpubuntu and options.component in ("main", "restricted"):
+                known_team_subscribed = False
+                source = publication.source_package_name
+                source_package = lpubuntu.getSourcePackage(name=source)
+                for subscription in source_package.getSubscriptions():
+                    subscriber = subscription.subscriber
+                    if subscriber.name in lputils.team_names:
+                        known_team_subscribed = True
+                        break
+                if not known_team_subscribed:
+                    if (
+                        YesNoQuestion().ask(
+                            "No known owning team subscribed to '%s'. "
+                            "Do you really want to promote?" % source,
+                            "no",
+                        )
+                        != "yes"
+                    ):
+                        return
+
     if options.dry_run:
         print("Dry run; no publications overridden.")
     else:
@@ -113,32 +139,8 @@ def change_overrides(options, packages):
         num_overridden = 0
         num_same = 0
 
-        # The MIR teams subscription is specific to Ubuntu
-        lpubuntu = None
-        if options.distribution.name == "ubuntu":
-            lpubuntu = options.launchpad.distributions["ubuntu"]
-
         for pubtype, publication in publications:
             if pubtype == "source":
-                if lpubuntu and options.component in ("main", "restricted"):
-                    known_team_subscribed = False
-                    source = publication.source_package_name
-                    source_package = lpubuntu.getSourcePackage(name=source)
-                    for subscription in source_package.getSubscriptions():
-                        subscriber = subscription.subscriber
-                        if subscriber.name in lputils.team_names:
-                            known_team_subscribed = True
-                            break
-                    if not known_team_subscribed:
-                        if (
-                            YesNoQuestion().ask(
-                                "No known owning team subscribed to '%s'. "
-                                "Do you really want to promote?" % source,
-                                "no",
-                            )
-                            != "yes"
-                        ):
-                            return
                 kwargs = source_kwargs
             else:
                 kwargs = binary_kwargs