Code review comment for lp:~paelzer/britney/hints-ubuntu-disco-fix-systemd-ppc-hint-that-never-works
Revision history for this message
| Łukasz Zemczak (sil2100) wrote | # |
review:
Approve
(not all of the changes)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Ok, so generally I would be -1 on setting this to a generalized hint. Adding a generic hint usually means "this is broken and we do not care about it ever again", which means we basically have 0 testing for the given arch. The need to bump the test every time, even though troublesome, does require someone to take a look and confirm if the same thing is broken as it was before. Sure, this is very annoying, but I wouldn't want us to completely stop caring about testing for a given arch.
That being said, do not treat my words as the definite 'no'. I completely understand how unproductive this currently is, and I myself am putting my own rationale in doubt, having mixed feelings if it actually matters that much. If there are other SRU members that would be +1 on making this generic for disco, I would not object.
So for now I will merge your change, but not commit the actual generalization. I'll try discussing this with other SRU members on our nearest meeting.