Code review comment for lp:~pablocastellano/ndisgtk/devel

Revision history for this message
Pablo Castellano (pablocastellano) wrote :

>> 72): 0.8.5 is already released so what's wrong? Why can't be translations changed?
> Planning for Debian Squeeze. And it's a click-tool anyway, and not targeted at
> people who use shortcuts. We can include it afterwards, for a release in 2012;
> although I hope that 0.8.6 can be the last release ever.

I understand that you are a Debian Developer and want the best for your
distribution but Squeeze could still provide 0.8.5 instead of any future
0.8.6. Moreover, AFAIK Squeeze hasn't a release date yet, and all
buttons but one have a shortcut, I'm not adding a shortcut to every
button. The development of ndisgtk can continue independently.

>> 74) It may be evil but at the end, pep8 is though to make python
>> code the most easily-readable possible, isn't it? Please consider it again.
> No.
>
> ndisgtk is not in active development anymore, it's just maintained where
> needed. The plan was to add an ndiswrapper feature to jockey, but I never
> started working on it.

You are right, since ndisgtk does its initial purpose and since ndisgtk
code is small, it's very maintainable but better readability means
better maintainability.

So, I don't understand your reasons.

What about 73)?

« Back to merge proposal