Code review comment for lp:~ovnicraft/openobject-addons/trunk-stock-picking-location-context

Hi Cristian,

It's an interesting feature suggestion, though I feel it might be confusing and counter-intuitive for users.

If you update your branch with the latest trunk, you'll see that the stock.move views have changed a lot, and the emphasis is on presenting clearly the pre-filled pickings/moves that are created by the system (it is much more common than creating picking manually from scratch). Moving the location/location_dest fields on the top of the forms is not an option, it will disrupt the layout and usability.

We could still apply your context patch, but I think it will be confusing because it's not obvious why the stock levels are modified. I'm also not sure users often use the quantity on hand when selecting products to move. And even if they did, having to repeatedly open and close the "search pop-up" to change the "source location" until you find the right location is not a very user-friendly solution, don't you think? No-one will think of doing that, or find it efficient to work, will they?
BTW there are other alternatives for finding locations where the product is available before creating the picking, in a more user-friendly manner.

If you insist on doing this patch, could you ask for feedback to the community, to make sure people would not consider it more confusing than useful? And in any case, please double-check your patch against the new v7 views (and be careful about inherited views which may replace the product_id field and not preserve your context)

Sorry for the conflicts caused by the long review delay...
Thanks!