Code review comment for lp:~oubiwann/ubuntu-accomplishments-system/946850-twisted-app

Revision history for this message
Jono Bacon (jonobacon) wrote :

Thanks so much, Duncan, for taking the time to work on this. I have a few questions, bearing in mind some of my more limited Twisted knowledge.

 * It looks like I needed to set my PYTHONPATH, is this the case?
 * I see you created AsyncAPI - does this literally just put these async orientated methods into a different class for the purposes of classification/naming, or does this do anything differently?
 * It looks like each of the classes in service.py overload a set of methods in Twisted (startService, stopService etc) and then applicationFactory in app.py gets everything up and running. Is this right?
 * In the notes you say "all blocking calls that are going to be made in functions/methods that return deferreds should either be converted to async code that utilizes Twisted to accomplish the same thing, or be run in a thread with deferToThread" - I thought that by using inline callbacks (as my code does already) this was doing this the Twisted way and not blocking?

Thanks!

   Jono

« Back to merge proposal