Code review comment for lp:~oubiwann/txaws/919862-add-makefile-old

Revision history for this message
Thomas Herve (therve) wrote :

[1]
+build-docs:
+ cd docs/sphinx; make html

+upload-docs: build-docs
+ python setup.py upload_docs --upload-dir=docs/html/

AFAIK there is no such doc, so you should probably remove that.

[2] It's 2012, it'd be nice to default to something more recent than python 2.5 :).

[3]
+ -@test -d .venv-$(VERSION) || virtualenv -p Python$(VERSION) .venv-$(VERSION)

It smells like OS X here. The Python2.X executables (with a capital P) don't exist on Linux.

Thanks!

review: Approve

« Back to merge proposal