Code review comment for lp:~oubiwann/txaws/484858-s3-scripts

Revision history for this message
Duncan McGreggor (oubiwann) wrote :

Robert made this comment in the merge proposal of a child branch:

> There is a bunch of duplication in the example scripts. I'd like to see that removed. Perhaps:
> - give them a if __name__ == guard
> - move the error/return etc callback support into script.py

There is a bunch of duplication... for now, that is intentional, as it offers an example of API usage: all a potential user/developer has to do is read the bin scripts to see how to use the API.

I did think about moving redundant code into a txaws.script module, but I chose in favor of clarity, sacrificing with redundancy.

If you don't this is a valid concern, I'm willing to be convinced :-)

review: Approve

« Back to merge proposal