Code review comment for lp:~osomon/webbrowser-app/ua-override
Revision history for this message
| Olivier Tilloy (osomon) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
> 83 +import Ubuntu.Components 0.1
> Seem not to be used
It is required, because I’m using units.gu(…).
> Just because I like small functions, I'd move the functionality of getting the
> domain from a url into it's own function (UserAgent.qml). Easier to read,
> easier to test, easier to (maybe) reuse.
Good idea, will do.