Merge lp:~osomon/webbrowser-app/ua-chromium-version-from-oxide into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Merged at revision: 1472
Proposed branch: lp:~osomon/webbrowser-app/ua-chromium-version-from-oxide
Merge into: lp:webbrowser-app
Diff against target: 43 lines (+4/-7)
2 files modified
debian/control (+1/-1)
src/Ubuntu/Web/UserAgent02.qml (+3/-6)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/ua-chromium-version-from-oxide
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
system-apps-ci-bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+291906@code.launchpad.net

Commit message

Use the chromium version exposed by oxide in the default UA string.

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2016-04-08 17:06:09 +0000
+++ debian/control 2016-04-14 15:11:09 +0000
@@ -115,7 +115,7 @@
115Pre-Depends: ${misc:Pre-Depends}115Pre-Depends: ${misc:Pre-Depends}
116Depends: ${misc:Depends},116Depends: ${misc:Depends},
117 ${shlibs:Depends},117 ${shlibs:Depends},
118 liboxideqt-qmlplugin (>= 1.12),118 liboxideqt-qmlplugin (>= 1.15),
119 qml-module-qtquick2 (>= 5.4),119 qml-module-qtquick2 (>= 5.4),
120 qml-module-qtquick-window2 (>= 5.3),120 qml-module-qtquick-window2 (>= 5.3),
121 qtdeclarative5-ubuntu-ui-toolkit-plugin (>= 1.3) | qtdeclarative5-ubuntu-ui-toolkit-plugin-gles (>= 1.3),121 qtdeclarative5-ubuntu-ui-toolkit-plugin (>= 1.3) | qtdeclarative5-ubuntu-ui-toolkit-plugin-gles (>= 1.3),
122122
=== modified file 'src/Ubuntu/Web/UserAgent02.qml'
--- src/Ubuntu/Web/UserAgent02.qml 2015-12-10 10:43:04 +0000
+++ src/Ubuntu/Web/UserAgent02.qml 2016-04-14 15:11:09 +0000
@@ -1,5 +1,5 @@
1/*1/*
2 * Copyright 2013-2015 Canonical Ltd.2 * Copyright 2013-2016 Canonical Ltd.
3 *3 *
4 * This file is part of webbrowser-app.4 * This file is part of webbrowser-app.
5 *5 *
@@ -17,6 +17,7 @@
17 */17 */
1818
19import QtQml 2.019import QtQml 2.0
20import com.canonical.Oxide 1.15
2021
21/*22/*
22 * Useful documentation:23 * Useful documentation:
@@ -57,11 +58,7 @@
57 // See chromium/src/content/webkit_version.h.in in oxide’s source tree.58 // See chromium/src/content/webkit_version.h.in in oxide’s source tree.
58 readonly property string _webkitVersion: "537.36"59 readonly property string _webkitVersion: "537.36"
5960
60 // See chromium/src/chrome/VERSION in oxide’s source tree.61 readonly property string _chromiumVersion: Oxide.chromiumVersion
61 // Note: the actual version number probably doesn’t matter that much,
62 // however its format does, so we probably don’t need to bump it
63 // every time we rebase on a newer chromium.
64 readonly property string _chromiumVersion: "35.0.1870.2"
6562
66 readonly property string _formFactor: smallScreen ? "Mobile" : ""63 readonly property string _formFactor: smallScreen ? "Mobile" : ""
6764

Subscribers

People subscribed via source and target branches

to status/vote changes: