Merge lp:~osomon/webbrowser-app/suggestions-always-rich-text into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 157
Merged at revision: 160
Proposed branch: lp:~osomon/webbrowser-app/suggestions-always-rich-text
Merge into: lp:webbrowser-app
Diff against target: 33 lines (+3/-2)
2 files modified
src/Ubuntu/Browser/Suggestions.qml (+1/-0)
tests/autopilot/webbrowser_app/tests/test_history.py (+2/-2)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/suggestions-always-rich-text
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Günter Schwann (community) Approve
Review via email: mp+167350@code.launchpad.net

Commit message

Always format the suggestions as rich text, to ensure ampersands are not incorrectly escaped.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Günter Schwann (schwann) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Ubuntu/Browser/Suggestions.qml'
--- src/Ubuntu/Browser/Suggestions.qml 2013-05-31 16:34:52 +0000
+++ src/Ubuntu/Browser/Suggestions.qml 2013-06-04 17:23:27 +0000
@@ -106,6 +106,7 @@
106 '<b><font color="#DD4814">$&</font></b>')106 '<b><font color="#DD4814">$&</font></b>')
107 }107 }
108 highlighted = highlighted.replace(new RegExp('&', 'g'), '&amp;')108 highlighted = highlighted.replace(new RegExp('&', 'g'), '&amp;')
109 highlighted = '<html>' + highlighted + '</html>'
109 return highlighted110 return highlighted
110 }111 }
111 }112 }
112113
=== modified file 'tests/autopilot/webbrowser_app/tests/test_history.py'
--- tests/autopilot/webbrowser_app/tests/test_history.py 2013-05-31 17:34:47 +0000
+++ tests/autopilot/webbrowser_app/tests/test_history.py 2013-06-04 17:23:27 +0000
@@ -13,7 +13,7 @@
13import sqlite313import sqlite3
14import time14import time
1515
16from testtools.matchers import Equals16from testtools.matchers import Contains, Equals
17from autopilot.matchers import Eventually17from autopilot.matchers import Eventually
1818
19from webbrowser_app.tests import BrowserTestCaseBase19from webbrowser_app.tests import BrowserTestCaseBase
@@ -125,7 +125,7 @@
125 entry = entries[2]125 entry = entries[2]
126 highlight = '<b><font color="#DD4814">Ubuntu</font></b>'126 highlight = '<b><font color="#DD4814">Ubuntu</font></b>'
127 url = "http://en.wikipedia.org/wiki/%s_(operating_system)" % highlight127 url = "http://en.wikipedia.org/wiki/%s_(operating_system)" % highlight
128 self.assertThat(entry.subText, Equals(url))128 self.assertThat(entry.subText, Contains(url))
129 self.pointing_device.move_to_object(entry)129 self.pointing_device.move_to_object(entry)
130 self.pointing_device.click()130 self.pointing_device.click()
131 webview = self.main_window.get_web_view()131 webview = self.main_window.get_web_view()

Subscribers

People subscribed via source and target branches

to status/vote changes: