Merge lp:~osomon/webbrowser-app/rewrite-uppercase-scheme into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 941
Merged at revision: 950
Proposed branch: lp:~osomon/webbrowser-app/rewrite-uppercase-scheme
Merge into: lp:webbrowser-app
Diff against target: 45 lines (+21/-3)
2 files modified
src/app/webbrowser/AddressBar.qml (+3/-3)
tests/unittests/qml/tst_AddressBar.qml (+18/-0)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/rewrite-uppercase-scheme
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+254093@code.launchpad.net

Commit message

Rewrite URLs with an uppercase scheme.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/app/webbrowser/AddressBar.qml'
--- src/app/webbrowser/AddressBar.qml 2015-01-23 10:30:19 +0000
+++ src/app/webbrowser/AddressBar.qml 2015-03-25 14:13:18 +0000
@@ -243,9 +243,9 @@
243 if (address.substr(0, 1) == "/") {243 if (address.substr(0, 1) == "/") {
244 return true244 return true
245 }245 }
246 if (address.match(/^https?:\/\//) ||246 if (address.match(/^https?:\/\//i) ||
247 address.match(/^file:\/\//) ||247 address.match(/^file:\/\//i) ||
248 address.match(/^[a-z]+:\/\//)) {248 address.match(/^[a-z]+:\/\//i)) {
249 return true249 return true
250 }250 }
251 if (address.split('/', 1)[0].match(/\.[a-zA-Z]{2,4}$/)) {251 if (address.split('/', 1)[0].match(/\.[a-zA-Z]{2,4}$/)) {
252252
=== modified file 'tests/unittests/qml/tst_AddressBar.qml'
--- tests/unittests/qml/tst_AddressBar.qml 2015-01-23 10:34:50 +0000
+++ tests/unittests/qml/tst_AddressBar.qml 2015-03-25 14:13:18 +0000
@@ -185,6 +185,24 @@
185 compare(addressBar.requestedUrl, data.requestedUrl)185 compare(addressBar.requestedUrl, data.requestedUrl)
186 }186 }
187187
188 function test_uppercaseSchemeShouldBeRewritten_data() {
189 return [
190 {text: "HTTP://WWW.UBUNTU.COM", requestedUrl: "http://www.ubuntu.com"},
191 {text: "HTTP://www.ubuntu.com", requestedUrl: "http://www.ubuntu.com"},
192 {text: "HTTPS://www.ubuntu.com", requestedUrl: "https://www.ubuntu.com"},
193 {text: "FILE:///usr/share/doc/ubuntu-online-tour/index.html", requestedUrl: "file:///usr/share/doc/ubuntu-online-tour/index.html"},
194 {text: "FTP://ubuntu.com", requestedUrl: "ftp://ubuntu.com"},
195 ]
196 }
197
198 function test_uppercaseSchemeShouldBeRewritten(data) {
199 typeString(data.text)
200 compare(addressBar.text, data.text)
201 keyClick(Qt.Key_Return)
202 validatedSpy.wait()
203 compare(addressBar.requestedUrl, data.requestedUrl)
204 }
205
188 function test_urlShouldBeSimplifiedWhenUnfocused_data() {206 function test_urlShouldBeSimplifiedWhenUnfocused_data() {
189 return [207 return [
190 {input: "http://www.ubuntu.com",208 {input: "http://www.ubuntu.com",

Subscribers

People subscribed via source and target branches

to status/vote changes: