Merge lp:~osomon/webbrowser-app/navigation-discard-selection into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 933
Merged at revision: 942
Proposed branch: lp:~osomon/webbrowser-app/navigation-discard-selection
Merge into: lp:webbrowser-app
Diff against target: 39 lines (+8/-2)
2 files modified
src/Ubuntu/Web/UbuntuWebView02.qml (+3/-1)
tests/autopilot/webbrowser_app/tests/test_selection.py (+5/-1)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/navigation-discard-selection
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+253332@code.launchpad.net

Commit message

Discard selection when navigating away.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Ubuntu/Web/UbuntuWebView02.qml'
--- src/Ubuntu/Web/UbuntuWebView02.qml 2015-02-16 11:51:20 +0000
+++ src/Ubuntu/Web/UbuntuWebView02.qml 2015-03-18 10:51:44 +0000
@@ -1,5 +1,5 @@
1/*1/*
2 * Copyright 2013-2014 Canonical Ltd.2 * Copyright 2013-2015 Canonical Ltd.
3 *3 *
4 * This file is part of webbrowser-app.4 * This file is part of webbrowser-app.
5 *5 *
@@ -257,6 +257,8 @@
257 if (loadEvent.url.toString() !== "data:text/html,chromewebdata") {257 if (loadEvent.url.toString() !== "data:text/html,chromewebdata") {
258 internal.lastLoadRequestStatus = loadEvent.type258 internal.lastLoadRequestStatus = loadEvent.type
259 }259 }
260 internal.dismissCurrentContextualMenu()
261 internal.dismissCurrentSelection()
260 }262 }
261263
262 readonly property int screenOrientation: Screen.orientation264 readonly property int screenOrientation: Screen.orientation
263265
=== modified file 'tests/autopilot/webbrowser_app/tests/test_selection.py'
--- tests/autopilot/webbrowser_app/tests/test_selection.py 2014-12-13 02:46:27 +0000
+++ tests/autopilot/webbrowser_app/tests/test_selection.py 2015-03-18 10:51:44 +0000
@@ -1,6 +1,6 @@
1# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-1# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
2#2#
3# Copyright 2014 Canonical3# Copyright 2014-2015 Canonical
4#4#
5# This program is free software: you can redistribute it and/or modify it5# This program is free software: you can redistribute it and/or modify it
6# under the terms of the GNU General Public License version 3, as published6# under the terms of the GNU General Public License version 3, as published
@@ -89,3 +89,7 @@
89 self.assertThat(self.rectangle.globalRect, Eventually(Equals(rect)))89 self.assertThat(self.rectangle.globalRect, Eventually(Equals(rect)))
90 self.actions.wait_until_destroyed()90 self.actions.wait_until_destroyed()
91 self.actions = self.main_window.get_selection_actions()91 self.actions = self.main_window.get_selection_actions()
92
93 def test_navigating_discards_selection(self):
94 self.main_window.go_back()
95 self.assert_selection_eventually_dismissed()

Subscribers

People subscribed via source and target branches

to status/vote changes: