webbrowser-app

Code review comment for lp:~osomon/webbrowser-app/limit-thumbnail-cache-size

  1. limit-thumbnail-cache-size
  2. Merge into trunk
Revision history for this message
Günter Schwann (schwann) wrote :

45 + m_thumbnailUtilsThread->deleteLater();
I'd call m_thumbnailUtilsThread->wait() and delete the thread directly instead

234 + QMetaObject::invokeMethod(&WebThumbnailUtils::instance(), "cacheThumbnail",
You could add the connection type Qt::QueuedConnection, to highlight (and make sure) that it's asynchronous.

148 + qint64 goal = MAX_CACHE_SIZE_IN_BYTES * 9 / 10;
So the max cache size is 90% of 5MB? Why?

« Back to merge proposal