Code review comment for lp:~osomon/webbrowser-app/itemSelector

Revision history for this message
Olivier Tilloy (osomon) wrote :

> In case there is no grouping - should the section delegate have height 0, and
> be set visible false?

Not needed: the listview internals already take care of that, so if there is no grouping the section delegates won’t even be instantiated. You can test it with e.g. http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_select.

> After every model.accept(), the itemSelector would become invisible (I guess).
> So in that case every model.accept() would be followed by a model.reject(). Is
> that correct?

No need to call selectorModel.reject(). Calling selectorModel.accept() already takes care of destroying the component and communicating the selected value back to the <select> element.

« Back to merge proposal