webbrowser-app

Merge lp:~osomon/webbrowser-app/increase-test-timeout into lp:webbrowser-app

  1. increase-test-timeout
  2. Merge into trunk
Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: no longer in the source branch.
Merged at revision: 295
Proposed branch: lp:~osomon/webbrowser-app/increase-test-timeout
Merge into: lp:webbrowser-app
Diff against target: 11 lines (+2/-1)
1 file modified
tests/autopilot/webbrowser_app/tests/__init__.py (+2/-1)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/increase-test-timeout
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Günter Schwann (community) Approve
Review via email: mp+183425@code.launchpad.net

Commit message

Increase the timeout for assert_page_eventually_loaded to make tests more reliable
when in a slow environment.

To post a comment you must log in.
Revision history for this message
Günter Schwann (schwann) wrote :

lgtm

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:295
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/292/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2856
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/445
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-amd64-ci/175
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-ci/175
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-ci/175/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-i386-ci/175
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/2862
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/2862/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2425
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/447
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/447/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/401
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/408

Click here to trigger a rebuild:
http://s-jenkins:8080/job/webbrowser-app-ci/292/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/webbrowser-app-autolanding/162/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2859
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/448/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-amd64-autolanding/106
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-autolanding/106/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-i386-autolanding/106
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/2865
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/2865/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2428
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/450/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
lp:~osomon/webbrowser-app/increase-test-timeout updated
295. By Olivier Tilloy

Increase the timeout for assert_page_eventually_loaded to make tests more reliable
when in a slow environment.

Approved by PS Jenkins bot, Günter Schwann.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/autopilot/webbrowser_app/tests/__init__.py'
--- tests/autopilot/webbrowser_app/tests/__init__.py 2013-08-29 16:28:44 +0000
+++ tests/autopilot/webbrowser_app/tests/__init__.py 2013-09-02 11:09:49 +0000
@@ -177,7 +177,8 @@
177 webview = self.main_window.get_current_webview()177 webview = self.main_window.get_current_webview()
178 self.assertThat(webview.url, Eventually(Equals(url)))178 self.assertThat(webview.url, Eventually(Equals(url)))
179 # loadProgress == 100 ensures that a page has actually loaded179 # loadProgress == 100 ensures that a page has actually loaded
180 self.assertThat(webview.loadProgress, Eventually(Equals(100)))180 self.assertThat(webview.loadProgress,
181 Eventually(Equals(100), timeout=20))
181 self.assertThat(webview.loading, Eventually(Equals(False)))182 self.assertThat(webview.loading, Eventually(Equals(False)))
182183
183184

Subscribers

People subscribed via source and target branches

to status/vote changes: