Code review comment for lp:~osomon/webbrowser-app/hyperlinks-blank-target

Revision history for this message
Olivier Tilloy (osomon) wrote :

As discussed on IRC, the approach suggested by Ugo would probably consume more memory (for each onclick handler), as opposed to more CPU consumption for the patch I’m proposing. We’d need numbers to back this hypothesis though.

Regardless, this is a temporary solution, the proper way of fixing this issue is to patch QtWebKit to implement decidePolicyForNewWindowAction(…).

This patch improves user experience by enabling something that doesn’t work without it, so let’s get it in as is, and work on a proper fix asap.

« Back to merge proposal