Merge lp:~osomon/webbrowser-app/disable-webview-when-activityview-visible into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 212
Merged at revision: 212
Proposed branch: lp:~osomon/webbrowser-app/disable-webview-when-activityview-visible
Merge into: lp:webbrowser-app
Diff against target: 29 lines (+1/-7)
2 files modified
src/Ubuntu/Components/Extras/Browser/ActivityView.qml (+0/-7)
src/Ubuntu/Components/Extras/Browser/Browser.qml (+1/-0)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/disable-webview-when-activityview-visible
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Günter Schwann (community) Approve
Review via email: mp+173156@code.launchpad.net

Commit message

Disable the current webview while the activity view is visible, thus avoiding mouse events to go through.

To post a comment you must log in.
Revision history for this message
Günter Schwann (schwann) wrote :

works fine

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Ubuntu/Components/Extras/Browser/ActivityView.qml'
--- src/Ubuntu/Components/Extras/Browser/ActivityView.qml 2013-07-04 11:37:16 +0000
+++ src/Ubuntu/Components/Extras/Browser/ActivityView.qml 2013-07-05 08:46:26 +0000
@@ -32,13 +32,6 @@
32 }32 }
33 }33 }
3434
35 MouseArea {
36 // Prevent mouse/touch events from propagating to the webview below.
37 anchors.fill: parent
38 hoverEnabled: true
39 onWheel: {}
40 }
41
42 Header {35 Header {
43 id: header36 id: header
44 title: tabs.selectedTab.title37 title: tabs.selectedTab.title
4538
=== modified file 'src/Ubuntu/Components/Extras/Browser/Browser.qml'
--- src/Ubuntu/Components/Extras/Browser/Browser.qml 2013-07-02 07:58:19 +0000
+++ src/Ubuntu/Components/Extras/Browser/Browser.qml 2013-07-05 08:46:26 +0000
@@ -277,6 +277,7 @@
277277
278 anchors.fill: parent278 anchors.fill: parent
279279
280 enabled: !activityView.visible
280 visible: tabsModel.currentWebview === webview281 visible: tabsModel.currentWebview === webview
281282
282 devicePixelRatio: browser.qtwebkitdpr283 devicePixelRatio: browser.qtwebkitdpr

Subscribers

People subscribed via source and target branches

to status/vote changes: