Merge lp:~osomon/webbrowser-app/disable-webview-when-activityview-visible into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 212
Merged at revision: 212
Proposed branch: lp:~osomon/webbrowser-app/disable-webview-when-activityview-visible
Merge into: lp:webbrowser-app
Diff against target: 29 lines (+1/-7)
2 files modified
src/Ubuntu/Components/Extras/Browser/ActivityView.qml (+0/-7)
src/Ubuntu/Components/Extras/Browser/Browser.qml (+1/-0)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/disable-webview-when-activityview-visible
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Günter Schwann (community) Approve
Review via email: mp+173156@code.launchpad.net

Commit message

Disable the current webview while the activity view is visible, thus avoiding mouse events to go through.

To post a comment you must log in.
Revision history for this message
Günter Schwann (schwann) wrote :

works fine

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/Components/Extras/Browser/ActivityView.qml'
2--- src/Ubuntu/Components/Extras/Browser/ActivityView.qml 2013-07-04 11:37:16 +0000
3+++ src/Ubuntu/Components/Extras/Browser/ActivityView.qml 2013-07-05 08:46:26 +0000
4@@ -32,13 +32,6 @@
5 }
6 }
7
8- MouseArea {
9- // Prevent mouse/touch events from propagating to the webview below.
10- anchors.fill: parent
11- hoverEnabled: true
12- onWheel: {}
13- }
14-
15 Header {
16 id: header
17 title: tabs.selectedTab.title
18
19=== modified file 'src/Ubuntu/Components/Extras/Browser/Browser.qml'
20--- src/Ubuntu/Components/Extras/Browser/Browser.qml 2013-07-02 07:58:19 +0000
21+++ src/Ubuntu/Components/Extras/Browser/Browser.qml 2013-07-05 08:46:26 +0000
22@@ -277,6 +277,7 @@
23
24 anchors.fill: parent
25
26+ enabled: !activityView.visible
27 visible: tabsModel.currentWebview === webview
28
29 devicePixelRatio: browser.qtwebkitdpr

Subscribers

People subscribed via source and target branches

to status/vote changes: