Code review comment for lp:~osomon/webbrowser-app/copy-image-to-clipboard

Revision history for this message
Olivier Tilloy (osomon) wrote :

In narrow layout, copying an image from the context menu crashes oxide.
Here is the stack trace:

#0 0x00007fffb62c7d7d in oxide::WebContextMenu::CopyImage () at ../../oxide/shared/browser/oxide_web_context_menu.cc:84
#1 0x00007fffc5317466 in ?? () from /usr/lib/x86_64-linux-gnu/libOxideQtQuick.so.0
#2 0x00007fffc5317eb6 in ?? () from /usr/lib/x86_64-linux-gnu/libOxideQtQuick.so.0
#3 0x00007fffc531825f in ?? () from /usr/lib/x86_64-linux-gnu/libOxideQtQuick.so.0
#4 0x00007ffff71f59e9 in QQmlObjectOrGadget::metacall (this=this@entry=0x7fffffffa370, type=type@entry=QMetaObject::InvokeMetaMethod, index=index@entry=5,
    argv=argv@entry=0x7fffffffa020) at qml/qqmlpropertycache.cpp:1557
#5 0x00007ffff71840b6 in CallMethod (object=..., index=5, returnType=returnType@entry=43, argCount=argCount@entry=0, argTypes=argTypes@entry=0x0,
    engine=engine@entry=0xc73470, callArgs=0x7fffc5e28390) at jsruntime/qv4qobjectwrapper.cpp:1143
#6 0x00007ffff7185227 in CallPrecise (object=..., data=..., engine=engine@entry=0xc73470, callArgs=callArgs@entry=0x7fffc5e28390)
    at jsruntime/qv4qobjectwrapper.cpp:1380
#7 0x00007ffff7185ded in QV4::QObjectMethod::callInternal (this=<optimized out>, callData=<optimized out>) at jsruntime/qv4qobjectwrapper.cpp:1858
#8 0x00007ffff719bfea in QV4::Object::call (d=0x7fffc5e28390, this=<optimized out>) at jsruntime/qv4object_p.h:324
#9 QV4::Runtime::callProperty (engine=0xc73470, nameIndex=<optimized out>, callData=0x7fffc5e28390) at jsruntime/qv4runtime.cpp:1002
#10 0x00007fff8c0c50c2 in ?? ()
#11 0x00007fff00000002 in ?? ()
#12 0x0000000000000008 in ?? ()
#13 0x00007fffffffa5f0 in ?? ()
#14 0x0000000000000028 in ?? ()
#15 0x00007fffb62c7cb8 in oxide::WebContextMenu::Close () at ../../oxide/shared/browser/oxide_web_context_menu.cc:77
#16 0x0000000000000000 in ?? ()

It appears that copyImage() is invoked after invoking close() on the menu context.

review: Needs Fixing

« Back to merge proposal