Merge lp:~osomon/webbrowser-app/bottomedgebar-autopilot-tests into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 1345
Merged at revision: 1349
Proposed branch: lp:~osomon/webbrowser-app/bottomedgebar-autopilot-tests
Merge into: lp:webbrowser-app
Diff against target: 52 lines (+7/-7)
3 files modified
src/app/webbrowser/Browser.qml (+1/-0)
tests/autopilot/webbrowser_app/emulators/browser.py (+4/-1)
tests/autopilot/webbrowser_app/tests/__init__.py (+2/-6)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/bottomedgebar-autopilot-tests
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+284892@code.launchpad.net

Commit message

Use the new bottom edge bar to open the tabs view in autopilot tests.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/app/webbrowser/Browser.qml'
--- src/app/webbrowser/Browser.qml 2016-01-28 22:12:27 +0000
+++ src/app/webbrowser/Browser.qml 2016-02-03 11:57:58 +0000
@@ -753,6 +753,7 @@
753753
754 MouseArea {754 MouseArea {
755 id: bottomEdgeBar755 id: bottomEdgeBar
756 objectName: "bottomEdgeBar"
756 anchors {757 anchors {
757 left: parent.left758 left: parent.left
758 right: parent.right759 right: parent.right
759760
=== modified file 'tests/autopilot/webbrowser_app/emulators/browser.py'
--- tests/autopilot/webbrowser_app/emulators/browser.py 2015-12-16 15:34:21 +0000
+++ tests/autopilot/webbrowser_app/emulators/browser.py 2016-02-03 11:57:58 +0000
@@ -1,6 +1,6 @@
1# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-1# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
2#2#
3# Copyright 2013-2015 Canonical3# Copyright 2013-2016 Canonical
4#4#
5# This program is free software: you can redistribute it and/or modify it5# This program is free software: you can redistribute it and/or modify it
6# under the terms of the GNU General Public License version 3, as published6# under the terms of the GNU General Public License version 3, as published
@@ -186,6 +186,9 @@
186 def get_bottom_edge_hint(self):186 def get_bottom_edge_hint(self):
187 return self.select_single("QQuickImage", objectName="bottomEdgeHint")187 return self.select_single("QQuickImage", objectName="bottomEdgeHint")
188188
189 def get_bottom_edge_bar(self):
190 return self.select_single(objectName="bottomEdgeBar", visible=True)
191
189 def get_bookmark_options(self):192 def get_bookmark_options(self):
190 return self.select_single(BookmarkOptions)193 return self.select_single(BookmarkOptions)
191194
192195
=== modified file 'tests/autopilot/webbrowser_app/tests/__init__.py'
--- tests/autopilot/webbrowser_app/tests/__init__.py 2016-01-21 10:29:17 +0000
+++ tests/autopilot/webbrowser_app/tests/__init__.py 2016-02-03 11:57:58 +0000
@@ -131,12 +131,8 @@
131 def open_tabs_view(self):131 def open_tabs_view(self):
132 self.assertFalse(self.main_window.wide)132 self.assertFalse(self.main_window.wide)
133 if model() == 'Desktop':133 if model() == 'Desktop':
134 chrome = self.main_window.chrome134 bar = self.main_window.get_bottom_edge_bar()
135 drawer_button = chrome.get_drawer_button()135 self.pointing_device.click_object(bar)
136 self.pointing_device.click_object(drawer_button)
137 chrome.get_drawer()
138 tabs_action = chrome.get_drawer_action("tabs")
139 self.pointing_device.click_object(tabs_action)
140 else:136 else:
141 self.drag_bottom_edge_upwards(0.75)137 self.drag_bottom_edge_upwards(0.75)
142 tabs_view = self.main_window.get_tabs_view()138 tabs_view = self.main_window.get_tabs_view()

Subscribers

People subscribed via source and target branches

to status/vote changes: