webbrowser-app

Merge lp:~osomon/webbrowser-app/bottomedgebar-autopilot-tests into lp:webbrowser-app

  1. bottomedgebar-autopilot-tests
  2. Merge into trunk
Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 1345
Merged at revision: 1349
Proposed branch: lp:~osomon/webbrowser-app/bottomedgebar-autopilot-tests
Merge into: lp:webbrowser-app
Diff against target: 52 lines (+7/-7)
3 files modified
src/app/webbrowser/Browser.qml (+1/-0)
tests/autopilot/webbrowser_app/emulators/browser.py (+4/-1)
tests/autopilot/webbrowser_app/tests/__init__.py (+2/-6)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/bottomedgebar-autopilot-tests
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+284892@code.launchpad.net

Commit message

Use the new bottom edge bar to open the tabs view in autopilot tests.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1345
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2598/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6309
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1351
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1351
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1351/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1351
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4847
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6320
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6320/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27267

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2598/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1345
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2599/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6312
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1352
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1352
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1352/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1352
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4849
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6323
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6323/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27272

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2599/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1345
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2601/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6318
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1354
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1354
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1354/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1354
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4854
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6329
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6329/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27280

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2601/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1345
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2603/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6327
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1356
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1356
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1356/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1356
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4859
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6338
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6338/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27307

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2603/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/webbrowser/Browser.qml'
2--- src/app/webbrowser/Browser.qml 2016-01-28 22:12:27 +0000
3+++ src/app/webbrowser/Browser.qml 2016-02-03 11:57:58 +0000
4@@ -753,6 +753,7 @@
5
6 MouseArea {
7 id: bottomEdgeBar
8+ objectName: "bottomEdgeBar"
9 anchors {
10 left: parent.left
11 right: parent.right
12
13=== modified file 'tests/autopilot/webbrowser_app/emulators/browser.py'
14--- tests/autopilot/webbrowser_app/emulators/browser.py 2015-12-16 15:34:21 +0000
15+++ tests/autopilot/webbrowser_app/emulators/browser.py 2016-02-03 11:57:58 +0000
16@@ -1,6 +1,6 @@
17 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
18 #
19-# Copyright 2013-2015 Canonical
20+# Copyright 2013-2016 Canonical
21 #
22 # This program is free software: you can redistribute it and/or modify it
23 # under the terms of the GNU General Public License version 3, as published
24@@ -186,6 +186,9 @@
25 def get_bottom_edge_hint(self):
26 return self.select_single("QQuickImage", objectName="bottomEdgeHint")
27
28+ def get_bottom_edge_bar(self):
29+ return self.select_single(objectName="bottomEdgeBar", visible=True)
30+
31 def get_bookmark_options(self):
32 return self.select_single(BookmarkOptions)
33
34
35=== modified file 'tests/autopilot/webbrowser_app/tests/__init__.py'
36--- tests/autopilot/webbrowser_app/tests/__init__.py 2016-01-21 10:29:17 +0000
37+++ tests/autopilot/webbrowser_app/tests/__init__.py 2016-02-03 11:57:58 +0000
38@@ -131,12 +131,8 @@
39 def open_tabs_view(self):
40 self.assertFalse(self.main_window.wide)
41 if model() == 'Desktop':
42- chrome = self.main_window.chrome
43- drawer_button = chrome.get_drawer_button()
44- self.pointing_device.click_object(drawer_button)
45- chrome.get_drawer()
46- tabs_action = chrome.get_drawer_action("tabs")
47- self.pointing_device.click_object(tabs_action)
48+ bar = self.main_window.get_bottom_edge_bar()
49+ self.pointing_device.click_object(bar)
50 else:
51 self.drag_bottom_edge_upwards(0.75)
52 tabs_view = self.main_window.get_tabs_view()

Subscribers

People subscribed via source and target branches

to status/vote changes: