Code review comment for lp:~osomon/unity-2d/custom-quicklists-dynamic

Revision history for this message
Ugo Riboni (uriboni) wrote :

Functionally it works OK. I tested it both with dejadup and with the example code.

The only issue that might be interesting to fix is that if the menu is already open, it's not updated. This leads to having some menu items that are not necessarily valid anymore. Not sure what will happen if you try to activate a menu item that the application has removed already.

review: Approve

« Back to merge proposal