Ubuntu
epiphany-browser package

Code review comment for lp:~osomon/ubuntu/maverick/epiphany-browser/user_agent

  1. Maverick (10.10)
  2. user_agent
  3. Merge into maverick
Revision history for this message
James Westby (james-w) wrote :

On Mon, 17 May 2010 11:20:44 -0000, Olivier Tilloy <email address hidden> wrote:
> I changed the @PACKAGEVERSION@ substitution to "maverick" to mimic Firefox's behaviour. My User-Agent string with ff in lucid is:
>
> Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.9.2.3) Gecko/20100423 Ubuntu/10.04 (lucid) Firefox/3.6.3
>
> so I figured the VendorComment should be set to the release codename, but I'm happy to keep the @PACKAGEVERSION@ substitution if that sounds more sensible.

I think that's more appropriate to have the minimal change.

Note that for 10.04 the version should be "10.04 LTS", not just "10.04".

Thanks,

James

« Back to merge proposal