Merge lp:~osomon/ubuntu-calendar-app/reload-function-not-signal into lp:ubuntu-calendar-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 99
Merged at revision: 104
Proposed branch: lp:~osomon/ubuntu-calendar-app/reload-function-not-signal
Merge into: lp:ubuntu-calendar-app
Diff against target: 48 lines (+5/-4)
3 files modified
EventListModel.qml (+3/-2)
EventViewBase.qml (+1/-1)
TimeLineBase.qml (+1/-1)
To merge this branch: bzr merge lp:~osomon/ubuntu-calendar-app/reload-function-not-signal
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Kunal Parmar Approve
Review via email: mp+183521@code.launchpad.net

Commit message

Make EventListModel.reload() a function, not a signal.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

looks good to me

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'EventListModel.qml'
--- EventListModel.qml 2013-03-27 23:09:07 +0000
+++ EventListModel.qml 2013-09-02 18:10:47 +0000
@@ -8,15 +8,16 @@
8 property var termStart: new Date()8 property var termStart: new Date()
9 property var termLength: Date.msPerDay9 property var termLength: Date.msPerDay
1010
11 signal reload11 signal reloaded
1212
13 onReload: {13 function reload() {
14 var t0 = termStart.getTime()14 var t0 = termStart.getTime()
15 var t1 = t0 + termLength15 var t1 = t0 + termLength
16 model.clear()16 model.clear()
17 DataService.getEvents(t0, t1, model)17 DataService.getEvents(t0, t1, model)
18 // for (var i = 0; i < model.count; ++i)18 // for (var i = 0; i < model.count; ++i)
19 // DataService.printEvent(model.get(i))19 // DataService.printEvent(model.get(i))
20 reloaded()
20 }21 }
21 Component.onCompleted: {22 Component.onCompleted: {
22 reload()23 reload()
2324
=== modified file 'EventViewBase.qml'
--- EventViewBase.qml 2013-06-02 02:33:33 +0000
+++ EventViewBase.qml 2013-09-02 18:10:47 +0000
@@ -23,7 +23,7 @@
23 termStart: dayStart23 termStart: dayStart
24 termLength: Date.msPerDay24 termLength: Date.msPerDay
2525
26 onReload: {26 onReloaded: {
27 modelRefreshed();27 modelRefreshed();
28 }28 }
29 }29 }
3030
=== modified file 'TimeLineBase.qml'
--- TimeLineBase.qml 2013-08-27 14:41:12 +0000
+++ TimeLineBase.qml 2013-09-02 18:10:47 +0000
@@ -14,7 +14,7 @@
14 termStart: bubbleOverLay.day.midnight()14 termStart: bubbleOverLay.day.midnight()
15 termLength: Date.msPerDay15 termLength: Date.msPerDay
1616
17 onReload: {17 onReloaded: {
18 bubbleOverLay.createEvents();18 bubbleOverLay.createEvents();
19 }19 }
20 }20 }

Subscribers

People subscribed via source and target branches

to status/vote changes: