Code review comment for lp:~osomon/qtubuntu-sensors/shield-against-nans

Revision history for this message
Loïc Minier (lool) wrote :

LGTM

Typo horizontal/vertical was obviously a mistake, and the nan fix is about making sure we only set the attributes which indeed are good values, so makes sense.

While at it, is it correct to set the altitude to 0 and to copy over the timestamp?

review: Approve

« Back to merge proposal