Code review comment for lp:~osomon/oxide/context-menu

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Thanks for working on this - I've added a few comments inline.

In addition to that, there's a few use cases that are missing:
- Open link / image / audio / video in new tab / window don't have any way to pass referrer information when appropriate. I'm not sure how best to handle that.
- Copy image to clipboard (for image + canvas)
- Controlling the media element (play / pause / mute)
- Save page (there should be a WebView API for this)
- Reload frame (there should be a WebView API for this).

It's ok to leave these cases unimplemented for this iteration, but we should have follow up bugs for them.

Out of interest - for the browser implementation, have you had a look at the logic in Chromium (particularly components/renderer_context_menu/context_menu_content_type.cc and chrome/browser/renderer_context_menu/render_view_context_menu.cc)?

review: Needs Fixing

« Back to merge proposal