Code review comment for ~osomon/network-manager:bionic-1.10.14-sru

Revision history for this message
Sebastien Bacher (seb128) wrote :

The update was agreed on after discussions on IRC, there is nothing obviously wrong and the packaging seems correct.

On the changelog we have a bug for the new version now, https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1809132 so it's probably best to include that one

The description could be updated to be

'New stable version (lp: #1809132), including
- Support private keys encrypted with AES-{192,256}-CBC in libnm (lp: #942856)
- Fix leak of DNS queries to local name servers when connecting to a
  full-tunnel VPN (CVE-2018-1000135) (lp: #1754671)'

Changing the mp to accepted, feel free to merge (with updated changelog for the extra lp references) and upload

review: Approve

« Back to merge proposal