Merge lp:~osomon/moovida/element_redirections into lp:moovida
Proposed by
Olivier Tilloy
Status: | Merged |
---|---|
Merged at revision: | not available |
Proposed branch: | lp:~osomon/moovida/element_redirections |
Merge into: | lp:moovida |
Diff against target: |
38 lines (+11/-11) 1 file modified
elisa-plugins/elisa/plugins/poblesec/player_video.py (+11/-11) |
To merge this branch: | bzr merge lp:~osomon/moovida/element_redirections |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michał Sawicz (community) | code functional | Approve | |
Review via email: mp+18219@code.launchpad.net |
To post a comment you must log in.
This branch fixes wrong handling of stream redirections in the general case where the "new-location" attribute of the message contains a full URI rather than just a filename.
Both cases are now handled gracefully, although it's unclear whether the latter is valid (it can be observed for Apple trailers so we need to support it anyway).
As a side effect, the fix improves the situation regarding bug #494713: for some mms:// streams Moovida previously crashed after entering an infinite loop of redirections, it now fails gracefully (reporting an error message to the user). It can be verified with e.g. mms://stream. amaonline. com/keyefm.
I also fixed this annoying issue that the Player was not logging anything.