Merge ~orndorffgrant/ubuntu/+source/ubuntu-advantage-tools:upload-28.1-mantic into ubuntu/+source/ubuntu-advantage-tools:ubuntu/devel

Proposed by Grant Orndorff
Status: Merged
Merge reported by: Grant Orndorff
Merged at revision: 6269f3c232d4d0130611a91eae04cb585da882ab
Proposed branch: ~orndorffgrant/ubuntu/+source/ubuntu-advantage-tools:upload-28.1-mantic
Merge into: ubuntu/+source/ubuntu-advantage-tools:ubuntu/devel
Diff against target: 78 lines (+15/-9)
4 files modified
debian/changelog (+10/-0)
uaclient/entitlements/fips.py (+2/-0)
uaclient/status.py (+2/-8)
uaclient/version.py (+1/-1)
Reviewer Review Type Date Requested Status
Lucas Kanashiro (community) Approve
Robie Basak Approve
Review via email: mp+445389@code.launchpad.net

Description of the change

This is release 28.1 of ubuntu-advantage-tools.
This adds fixes for two bugs found during verification of 28, which is currently in -proposed.

SRU Bug: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2017949

To post a comment you must log in.
Revision history for this message
Robie Basak (racb) wrote :

I don't see any SRU implications. Good job finding this before (SRU) release.

review: Approve
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks Grant! LGTM. As it was already approved by Robie, I just uploaded it to Mantic:

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading ubuntu-advantage-tools_28.1.dsc: done.
  Uploading ubuntu-advantage-tools_28.1.tar.xz: done.
  Uploading ubuntu-advantage-tools_28.1_source.changes: done.
Successfully uploaded packages.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 6a53910..85d1272 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
1ubuntu-advantage-tools (28.1) mantic; urgency=medium
2
3 * New upstream release 28.1 (LP: #2017949)
4 - fips: ensure shim-signed is updated to the version in the fips repo
5 if necessary
6 - status: fix bug where an existing status cache could influence the
7 simulated status output
8
9 -- Grant Orndorff <grant.orndorff@canonical.com> Mon, 26 Jun 2023 15:05:11 -0400
10
1ubuntu-advantage-tools (28) mantic; urgency=medium11ubuntu-advantage-tools (28) mantic; urgency=medium
212
3 * d/ubuntu-advantage-tools.postinst:13 * d/ubuntu-advantage-tools.postinst:
diff --git a/uaclient/entitlements/fips.py b/uaclient/entitlements/fips.py
index 42f0431..21b3ea2 100644
--- a/uaclient/entitlements/fips.py
+++ b/uaclient/entitlements/fips.py
@@ -27,6 +27,7 @@ CONDITIONAL_PACKAGES_EVERYWHERE = [
27 "strongswan-hmac",27 "strongswan-hmac",
28 "openssh-client",28 "openssh-client",
29 "openssh-server",29 "openssh-server",
30 "shim-signed",
30]31]
31CONDITIONAL_PACKAGES_OPENSSH_HMAC = [32CONDITIONAL_PACKAGES_OPENSSH_HMAC = [
32 "openssh-client-hmac",33 "openssh-client-hmac",
@@ -112,6 +113,7 @@ class FIPSCommonEntitlement(repo.RepoEntitlement):
112 "libgcrypt20",113 "libgcrypt20",
113 "libgcrypt20-hmac",114 "libgcrypt20-hmac",
114 "fips-initramfs-generic",115 "fips-initramfs-generic",
116 "shim-signed",
115 ]117 ]
116118
117 @property119 @property
diff --git a/uaclient/status.py b/uaclient/status.py
index aecd69f..1f0b362 100644
--- a/uaclient/status.py
+++ b/uaclient/status.py
@@ -507,20 +507,14 @@ def simulate_status(
507 event.info("This token is not valid.\n" + message.msg + "\n")507 event.info("This token is not valid.\n" + message.msg + "\n")
508 ret = 1508 ret = 1
509509
510 status_cache = cfg.read_cache("status-cache")510 resources = get_available_resources(cfg)
511 if status_cache:
512 resources = status_cache.get("services")
513 else:
514 resources = get_available_resources(cfg)
515
516 entitlements = contract_info.get("resourceEntitlements", [])
517
518 inapplicable_resources = [511 inapplicable_resources = [
519 resource["name"]512 resource["name"]
520 for resource in sorted(resources, key=lambda x: x["name"])513 for resource in sorted(resources, key=lambda x: x["name"])
521 if not resource["available"]514 if not resource["available"]
522 ]515 ]
523516
517 entitlements = contract_info.get("resourceEntitlements", [])
524 for resource in resources:518 for resource in resources:
525 entitlement_name = resource.get("name", "")519 entitlement_name = resource.get("name", "")
526 try:520 try:
diff --git a/uaclient/version.py b/uaclient/version.py
index 75e0f2c..ff640c2 100644
--- a/uaclient/version.py
+++ b/uaclient/version.py
@@ -15,7 +15,7 @@ from uaclient.defaults import CANDIDATE_CACHE_PATH, UAC_RUN_PATH
15from uaclient.exceptions import ProcessExecutionError15from uaclient.exceptions import ProcessExecutionError
16from uaclient.system import subp16from uaclient.system import subp
1717
18__VERSION__ = "28"18__VERSION__ = "28.1"
19PACKAGED_VERSION = "@@PACKAGED_VERSION@@"19PACKAGED_VERSION = "@@PACKAGED_VERSION@@"
2020
21CANDIDATE_REGEX = r"Candidate: (?P<candidate>.*?)\n"21CANDIDATE_REGEX = r"Candidate: (?P<candidate>.*?)\n"

Subscribers

People subscribed via source and target branches

to status/vote changes: