Merge ~orndorffgrant/ubuntu/+source/ubuntu-advantage-tools:upload-28.1-mantic into ubuntu/+source/ubuntu-advantage-tools:ubuntu/devel

Proposed by Grant Orndorff
Status: Merged
Merge reported by: Grant Orndorff
Merged at revision: 6269f3c232d4d0130611a91eae04cb585da882ab
Proposed branch: ~orndorffgrant/ubuntu/+source/ubuntu-advantage-tools:upload-28.1-mantic
Merge into: ubuntu/+source/ubuntu-advantage-tools:ubuntu/devel
Diff against target: 78 lines (+15/-9)
4 files modified
debian/changelog (+10/-0)
uaclient/entitlements/fips.py (+2/-0)
uaclient/status.py (+2/-8)
uaclient/version.py (+1/-1)
Reviewer Review Type Date Requested Status
Lucas Kanashiro (community) Approve
Robie Basak Approve
Review via email: mp+445389@code.launchpad.net

Description of the change

This is release 28.1 of ubuntu-advantage-tools.
This adds fixes for two bugs found during verification of 28, which is currently in -proposed.

SRU Bug: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2017949

To post a comment you must log in.
Revision history for this message
Robie Basak (racb) wrote :

I don't see any SRU implications. Good job finding this before (SRU) release.

review: Approve
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks Grant! LGTM. As it was already approved by Robie, I just uploaded it to Mantic:

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading ubuntu-advantage-tools_28.1.dsc: done.
  Uploading ubuntu-advantage-tools_28.1.tar.xz: done.
  Uploading ubuntu-advantage-tools_28.1_source.changes: done.
Successfully uploaded packages.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 6a53910..85d1272 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,13 @@
6+ubuntu-advantage-tools (28.1) mantic; urgency=medium
7+
8+ * New upstream release 28.1 (LP: #2017949)
9+ - fips: ensure shim-signed is updated to the version in the fips repo
10+ if necessary
11+ - status: fix bug where an existing status cache could influence the
12+ simulated status output
13+
14+ -- Grant Orndorff <grant.orndorff@canonical.com> Mon, 26 Jun 2023 15:05:11 -0400
15+
16 ubuntu-advantage-tools (28) mantic; urgency=medium
17
18 * d/ubuntu-advantage-tools.postinst:
19diff --git a/uaclient/entitlements/fips.py b/uaclient/entitlements/fips.py
20index 42f0431..21b3ea2 100644
21--- a/uaclient/entitlements/fips.py
22+++ b/uaclient/entitlements/fips.py
23@@ -27,6 +27,7 @@ CONDITIONAL_PACKAGES_EVERYWHERE = [
24 "strongswan-hmac",
25 "openssh-client",
26 "openssh-server",
27+ "shim-signed",
28 ]
29 CONDITIONAL_PACKAGES_OPENSSH_HMAC = [
30 "openssh-client-hmac",
31@@ -112,6 +113,7 @@ class FIPSCommonEntitlement(repo.RepoEntitlement):
32 "libgcrypt20",
33 "libgcrypt20-hmac",
34 "fips-initramfs-generic",
35+ "shim-signed",
36 ]
37
38 @property
39diff --git a/uaclient/status.py b/uaclient/status.py
40index aecd69f..1f0b362 100644
41--- a/uaclient/status.py
42+++ b/uaclient/status.py
43@@ -507,20 +507,14 @@ def simulate_status(
44 event.info("This token is not valid.\n" + message.msg + "\n")
45 ret = 1
46
47- status_cache = cfg.read_cache("status-cache")
48- if status_cache:
49- resources = status_cache.get("services")
50- else:
51- resources = get_available_resources(cfg)
52-
53- entitlements = contract_info.get("resourceEntitlements", [])
54-
55+ resources = get_available_resources(cfg)
56 inapplicable_resources = [
57 resource["name"]
58 for resource in sorted(resources, key=lambda x: x["name"])
59 if not resource["available"]
60 ]
61
62+ entitlements = contract_info.get("resourceEntitlements", [])
63 for resource in resources:
64 entitlement_name = resource.get("name", "")
65 try:
66diff --git a/uaclient/version.py b/uaclient/version.py
67index 75e0f2c..ff640c2 100644
68--- a/uaclient/version.py
69+++ b/uaclient/version.py
70@@ -15,7 +15,7 @@ from uaclient.defaults import CANDIDATE_CACHE_PATH, UAC_RUN_PATH
71 from uaclient.exceptions import ProcessExecutionError
72 from uaclient.system import subp
73
74-__VERSION__ = "28"
75+__VERSION__ = "28.1"
76 PACKAGED_VERSION = "@@PACKAGED_VERSION@@"
77
78 CANDIDATE_REGEX = r"Candidate: (?P<candidate>.*?)\n"

Subscribers

People subscribed via source and target branches

to status/vote changes: