Ubuntu
ubuntu-advantage-tools package

Code review comment for ~orndorffgrant/ubuntu/+source/ubuntu-advantage-tools:upload-27.11.3-kinetic

  1. Git
  2. lp:~orndorffgrant/ubuntu/+source/ubuntu-advantage-tools
  3. upload-27.11.3-kinetic
  4. Merge into ubuntu/devel
Revision history for this message
Robie Basak (racb) wrote :

SRU review.

I flagged the entire "apt news" concept as needing leadership approval in https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1992026/comments/17, and I don't think I should accept this into proposed until that is resolved.

Apart from that this looks fine from an SRU perspective, from a quick review to look for significant changes that would impact the system and/or existing users (I've not reviewed every line). I made a couple of comments inline, but I don't think we need to block on them.

« Back to merge proposal