Code review comment for lp:~optimisme/pantheon-files/fix-995762

Revision history for this message
Victor Martinez (victored) wrote :

Superb work!

A couple of suggestions:

* Instead of the new marlin.vapi file, "extern void marlin_connect_server_dialog (Gtk.Widget widget);" could be added to plugin.vala
* Coding style for vala code: http://master.elementaryos.org/docs/code/code-style
* Coding style for C code: follow style of source file.
* Remove the related code from pantheon-files-ui.xml instead of commenting it out. Having dead code is not desired.

Everything else seems nicely done.

review: Needs Fixing

« Back to merge proposal