Code review comment for lp:~openstack-ubuntu-packagers/ubuntu/natty/nova/ubuntu-natty-packaging-changes

On 19-11-2010 15:49, Chuck Short wrote:
>>> + - Add python-greenlet as a build dependency.
>> Why?
> Nova.sh requires you to install it. And its required in the
> tools/pip-requires. If this is outdated then this change can be
> dropped.

It seems there's some ordering of builds or whatnot that gets messed up
if they don't do it that way. They're workarounds if you're using
virtualenv. We don't use python-greenlet directly, so shouldn't have to
add it.

>>> + * debian/nova-*.conf: Update configs due to changes to nova-api.
>> Not all the changes you made to the conf files are due to change in
>> nova-api. They're due to all sorts of things.
> So should I phrase it as "due to changes in nova between maverick and natty?"

Maybe "debian/nova-*.conf: Include flags that were added upstream since
last snapshot."?

Or even just "debian/nova-*.conf: Update flagfiles.". Vague is better
than wrong/misleading.

>> This is fine, but soon won't be needed anymore, just FYI. The API server
>> doesn't use them, so it's a bug that it needs them there.
> Agreed, but if people want to test it right now they will have to add
> it to /etc/nova/nova-api.conf.

Right, exactly. That's why I said it was fine :)

> Ill add a bug with you guys.

Cool, thanks.

--
Soren Hansen
Ubuntu Developer http://www.ubuntu.com/
OpenStack Developer http://www.openstack.org/