Code review comment for lp:~openstack-gd/nova/lp708740

Revision history for this message
Vish Ishaya (vishvananda) wrote :

I definitely would prefer to have no exceptions getting eaten. It makes debugging user issues a lot more difficult.
On Jan 31, 2011, at 5:44 AM, Thierry Carrez wrote:

> Note that I don't deny the existence of a bug, I'm just trying to see if that's a bug we can release with or one that justifies a late exception.
>
> If all it affects is currently-non-existent packaging that would make proper use of daemonization, then I don't think it's worth it. That work-in-progress packaging could even carry the necessary patch.
>
> That said, it looks rather contained, and Soren can probably sync the fixing of Ubuntu packaging so that this does not break it. If you can get two nova-core approvals today on this one saying it's harmless, I won't oppose it.
> --
> https://code.launchpad.net/~openstack-gd/nova/lp708740/+merge/47838
> You are subscribed to branch lp:nova.

« Back to merge proposal