Code review comment for lp:~openstack-charmers/charms/trusty/nova-cloud-controller/0mq

UOSCI bot says:
This MP triggered a test on the Ubuntu OSCI system. Here is a summary of results.

#500 nova-cloud-controller-next for gnuoy mp238878
charm_unit_test

This build:
http://10.98.191.181:8080/job/charm_unit_test/500/

MP URL:
https://code.launchpad.net/~openstack-charmers/charms/trusty/nova-cloud-controller/0mq/+merge/238878

Proposed branch:
lp:~openstack-charmers/charms/trusty/nova-cloud-controller/0mq

Results summary:
    UNIT FAIL: unit-test failed

UNIT Results (max last 25 lines) from
/var/lib/jenkins/workspace/charm_unit_test/unit-test.500:
    return func(*args, **keywargs)
  File "/var/lib/jenkins/checkout/nova-cloud-controller/unit_tests/test_nova_cc_hooks.py", line 117, in test_config_changed_with_upgrade
    hooks.config_changed()
  File "hooks/nova_cc_utils.py", line 896, in wrapped_f
    f(*args)
  File "hooks/charmhelpers/core/host.py", line 269, in wrapped_f
    f(*args)
  File "hooks/nova_cc_hooks.py", line 172, in config_changed
    zeromq_configuration_relation_joined(rid)
  File "hooks/charmhelpers/contrib/openstack/utils.py", line 507, in wrapped_f
    " before %s" % ostack_release)
Exception: This hook is not supported on releases before juno

Name Stmts Miss Cover Missing
-----------------------------------------------------
hooks/nova_cc_context 151 109 28% 21-28, 39-41, 48-59, 65-79, 86-104, 116-169, 180-195, 203-204, 208, 212-214, 219, 222-236, 242-256, 273-276, 281-283
hooks/nova_cc_hooks 453 147 68% 135-138, 151-152, 178, 189-190, 194, 229, 234-239, 250, 330-333, 341-344, 350-353, 363-379, 388-390, 400-414, 418-427, 513, 523, 527-528, 581, 587-597, 602-613, 623-633, 638-677, 687-702, 710-714, 739-748, 772, 777-785, 811, 863, 871, 875-878
hooks/nova_cc_utils 447 115 74% 296-301, 312-315, 325-326, 382, 384, 428-430, 434, 448-456, 463-468, 472-486, 592-594, 599-602, 607, 611, 635-636, 650-652, 673-674, 680-703, 707-713, 717-723, 729, 735, 742, 753-757, 842, 902-905, 909-915, 919-921, 925-928, 932-944
-----------------------------------------------------
TOTAL 1051 371 65%
----------------------------------------------------------------------
Ran 97 tests in 10.713s

FAILED (errors=1)
make: *** [unit_test] Error 1

Ubuntu OSCI Jenkins is currently in development on a Canonical private network, but we plan to publish results to a public instance soon. Tests are triggered if the proposed branch rev changes, or if the MP is placed into "Needs review" status after being otherwise for >= 1hr. Human review of results is still recommended.
http://10.98.191.181:8080/