Merge lp:~openstack-charmers/charms/precise/nova-compute/ceilometer-agent into lp:~charmers/charms/precise/nova-compute/trunk

Proposed by James Page
Status: Merged
Merged at revision: 52
Proposed branch: lp:~openstack-charmers/charms/precise/nova-compute/ceilometer-agent
Merge into: lp:~charmers/charms/precise/nova-compute/trunk
Diff against target: 76 lines (+22/-2)
4 files modified
hooks/nova_compute_hooks.py (+6/-0)
hooks/nova_compute_utils.py (+6/-1)
metadata.yaml (+4/-1)
templates/havana/nova.conf (+6/-0)
To merge this branch: bzr merge lp:~openstack-charmers/charms/precise/nova-compute/ceilometer-agent
Reviewer Review Type Date Requested Status
Marco Ceppi (community) Abstain
Adam Gandelman (community) Approve
Review via email: mp+197751@code.launchpad.net

Description of the change

Add subordinate interface to allow ceilometer-agent charm to pass
configuration to nova.

To post a comment you must log in.
Revision history for this message
Adam Gandelman (gandelman-a) wrote :

Looks like a simple but useful change. Will wait till the ceilometer agent/server charms officially hit the store before merging this.

review: Approve
Revision history for this message
Marco Ceppi (marcoceppi) :
review: Abstain

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added symlink 'hooks/nova-ceilometer-relation-changed'
=== target is u'nova_compute_hooks.py'
=== added symlink 'hooks/nova-ceilometer-relation-joined'
=== target is u'nova_compute_hooks.py'
=== modified file 'hooks/nova_compute_hooks.py'
--- hooks/nova_compute_hooks.py 2013-11-08 05:48:58 +0000
+++ hooks/nova_compute_hooks.py 2013-12-04 16:30:15 +0000
@@ -209,6 +209,12 @@
209 amqp_joined(relation_id=r_id)209 amqp_joined(relation_id=r_id)
210210
211211
212@hooks.hook('nova-ceilometer-relation-changed')
213@restart_on_change(restart_map())
214def nova_ceilometer_relation_changed():
215 CONFIGS.write_all()
216
217
212def main():218def main():
213 try:219 try:
214 hooks.execute(sys.argv)220 hooks.execute(sys.argv)
215221
=== modified file 'hooks/nova_compute_utils.py'
--- hooks/nova_compute_utils.py 2013-11-01 16:11:43 +0000
+++ hooks/nova_compute_utils.py 2013-12-04 16:30:15 +0000
@@ -69,7 +69,12 @@
69 context.OSConfigFlagContext(),69 context.OSConfigFlagContext(),
70 CloudComputeContext(),70 CloudComputeContext(),
71 NovaComputeLibvirtContext(),71 NovaComputeLibvirtContext(),
72 NovaComputeCephContext()],72 NovaComputeCephContext(),
73 context.SubordinateConfigContext(
74 interface='nova-ceilometer',
75 service='nova',
76 config_file=NOVA_CONF,
77 )],
73 },78 },
74}79}
7580
7681
=== modified file 'metadata.yaml'
--- metadata.yaml 2013-08-01 23:21:58 +0000
+++ metadata.yaml 2013-12-04 16:30:15 +0000
@@ -6,7 +6,7 @@
6 addition to its "native" API (the OpenStack API), it also supports the Amazon6 addition to its "native" API (the OpenStack API), it also supports the Amazon
7 EC2 API.7 EC2 API.
8categories:8categories:
9 - openstack9 - openstack
10provides:10provides:
11 cloud-compute:11 cloud-compute:
12 interface: nova-compute12 interface: nova-compute
@@ -22,6 +22,9 @@
22 nrpe-external-master:22 nrpe-external-master:
23 interface: nrpe-external-master23 interface: nrpe-external-master
24 scope: container24 scope: container
25 nova-ceilometer:
26 interface: nova-ceilometer
27 scope: container
25peers:28peers:
26 compute-peer:29 compute-peer:
27 interface: nova30 interface: nova
2831
=== modified file 'templates/havana/nova.conf'
--- templates/havana/nova.conf 2013-11-01 22:05:27 +0000
+++ templates/havana/nova.conf 2013-12-04 16:30:15 +0000
@@ -84,3 +84,9 @@
84{% if live_migration_uri -%}84{% if live_migration_uri -%}
85live_migration_uri = {{ live_migration_uri }}85live_migration_uri = {{ live_migration_uri }}
86{% endif -%}86{% endif -%}
87
88{% if sections and 'DEFAULT' in sections -%}
89{% for key, value in sections['DEFAULT'] -%}
90{{ key }} = {{ value }}
91{% endfor -%}
92{% endif -%}
87\ No newline at end of file93\ No newline at end of file

Subscribers

People subscribed via source and target branches